Optimize consumer messages sequences for multiple subjects #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/consumer.go
Outdated
| @@ -3295,6 +3295,11 @@ func (o *consumer) getNextMsg() (*jsPubMsg, uint64, error) { | |||
| o.updateSkipped(uint64(filter.currentSeq)) | |||
| } | |||
| } | |||
|
|
|||
| // If we're sure that this filter has continuous sequence of messages, skip looking up other filters. | |||
| if filter.currentSeq == nextSeq && sseq == filter.currentSeq && err != ErrStoreEOF { | |||
If consumer with multiple subjects encountered a sequnece of messages from the same subject, it tried to load messages from other subjects in some cases. This checks for that scenario and optimizes it by early returning. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
jarema-optimize-consumer-sequences
branch
from
0fe17ef
to
7c1c4ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If consumer with multiple subjects encountered a sequnece of messages in a row from the same subject, it tried to load messages from other subjects in some cases.
This checks for that scenario and optimizes it by early returning.
I added a temporary instrumentation to check for how many times fetching new messages is called, and it seems that it cuts those calls according to assumptions. Though it being internal, it's really hard to show that in test.
Signed-off-by: Tomasz Pietrek tomasz@nats.io